Skip to content

Code Review

๋‚จ์ •ํ˜ธ edited this page Nov 19, 2019 · 1 revision

Rule

  • Code Style์„ ์ง€์ ํ•˜์ง€ ์•Š๊ธฐ
    • Lint & Prettier ์„ค์ •์—์„œ ํ•ฉ์˜๋ณด๊ธฐ
  • ๋ฆฌ๋ทฐ์–ด&์ฝ”๋“œ์ž‘์„ฑ์ž๋Š” ์ ๊ทน์ ์œผ๋กœ ์ž์‹ ์˜ ์ƒ๊ฐ์„ ๋งํ•˜๊ณ  ํ”ผ๋“œ๋ฐฑ ํ•˜๊ธฐ
  • ๋ฆฌ๋ทฐ์–ด๋Š” ์ฝ”๋“œ ์ž‘์„ฑ์ž์— ๋Œ€ํ•ด ์ธ์‹ ๊ณต๊ฒฉ ํ•˜์ง€ ์•Š๊ธฐ
  • ๋ฆฌ๋ทฐ์–ด๋Š” ์ตœ์†Œ 2์‹œ๊ฐ„์„ ๋“ค์—ฌ ๋ฆฌ๋ทฐํ•  ์ฝ”๋“œ๋ฅผ ๋ถ„์„ํ•˜๊ธฐ
  • ์ฝ”๋“œ์ž‘์„ฑ์ž๋Š” ์ž์‹ ์ด ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ•˜๋ฉด์„œ ์ƒ๊ฐํ–ˆ๋˜ ๊ณ ๋ฏผ๋“ค์„ ์—ฌ๊ณผ์—†์ด ๊ณต์œ ํ•˜๊ธฐ
  • ์ฝ”๋“œ์ž‘์„ฑ์ž๋Š” PRํ•˜๊ธฐ ์ „์— ์ž์‹ ์˜ ์ฝ”๋“œ์— ๋Œ€ํ•ด ํ…Œ์ŠคํŠธ๋ฅผ ํ†ตํ•ด ๊ฒ€์ฆํ•˜๊ธฐ
Clone this wiki locally