Replace Makefile with turborepo #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
And task name in fix ci.yaml And fix Node version in workflows Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
…h the task "conformance" Signed-off-by: Timo Stamm <ts@timostamm.de>
…h the task "conformance" Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
commented
Aug 30, 2024
| @@ -32,7 +32,7 @@ export function replaceDependencies( | |||
| ): PackageJson | null { | |||
| const modifiedPackageNames = new Set<string>(); | |||
| const replacedPackageNames = new Map<string, string>(); | |||
| const copy = structuredClone(pkg) as PackageJson; | |||
| const copy = clonePackageJson(pkg); | |||
There was a problem hiding this comment.
Noticed when running tests in a matrix:
structuredClone is not available in Node.js 16, but the package advertises compatibility. This fixes the issue.
packages/connect-web/turbo.json
Outdated
Comment on lines
13
to
18
| "conformance": { | ||
| "dependsOn": [ | ||
| "conformance:node:promise", | ||
| "conformance:node:callback" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
With the task "conformance", we run tests for @connectrpc/connect-web only on Node.js. Since browsers may not be available on the developer's machine, it seems more friendly to make this an opt in.
In effect, npm run all will run everything but tests on browsers, browserstack, and cloudflare.
Comment on lines
+147
to
+156
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: "npm" | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: .turbo | ||
| key: ${{ runner.os }}/test/${{ github.sha }} | ||
| restore-keys: ${{ runner.os }}/test | ||
| - run: npm ci |
There was a problem hiding this comment.
This code block seems to be repeated, we can use a composite action instead an use that as a single step.
There was a problem hiding this comment.
True, but a composite action is only 20 lines shorter overall. Switched to a matrix instead in 225881e.
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
force-pushed
the
tstamm/replace-make-with-turbo
branch
from
58ed288
to
225881e
Compare
This was referenced Sep 2, 2024
srikrsna-buf
approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turborepo gives us more control over running tasks in a monorepo, and it caches quite nicely.
For example, when a task is run from a package directory, all its prerequisites run automatically:
Closes #798.