Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response header management in Fastify plugin #517

Merged
merged 5 commits into from
Mar 7, 2023
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/connect-fastify/src/fastify-connect-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,17 @@ export function fastifyConnectPlugin(
req.body as JsonValue | undefined
)
);
// Fastify maintains response headers both on the reply object and on the raw response.
timostamm marked this conversation as resolved.
Show resolved Hide resolved
// So before we hand off to vanilla node, we need to make sure the headers from
// reply are copied over to the raw response. reply.send does this automatically, but
// we are not using reply.send with this plugin.
// Note that we are intentionally making reply headers take precedence to adhere to
// Fastify's contract: https://www.fastify.io/docs/latest/Reference/Reply/#getheaders
timostamm marked this conversation as resolved.
Show resolved Hide resolved
for (const [key, value] of Object.entries(reply.getHeaders())) {
if (value !== undefined) {
reply.raw.setHeader(key, value);
}
}
await universalResponseToNodeResponse(uRes, reply.raw);
}
);
Expand Down