Add client support for Connect HTTP GET requests #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchadwick-buf
force-pushed
the
jchadwick/unary-get-support
branch
from
aedf5fa
to
bcc2ea7
Compare
jchadwick-buf
changed the title
timostamm
reviewed
May 9, 2023
| /** | ||
| * @private Internal code, does not follow semantic versioning. | ||
| */ | ||
| export function transformConnectPostToGetRequest< |
Comment on lines
+30
to
+31
| // TODO(jchadwick-buf): Three regex replaces seems excessive. | ||
| // Can we make protoBase64.enc more flexible? |
There was a problem hiding this comment.
protobuf-es uses this for JSON, and it doesn't seem ideal to add complexity, bundle size there for a feature that is not used by protobuf-es. I agree this isn't pretty, but I am not sure we have a really good alternative.
timostamm
reviewed
May 10, 2023
There was a problem hiding this comment.
We'll need a PR description. Aside from the comment nit below, and #620 (comment), this looks ready to merge to me.
timostamm
approved these changes
May 10, 2023
…hadwick/unary-get-support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Connect HTTP GET requests on the client, both in Node.JS and the browser. Requires specifying the transport option
useHttpGetfor now to enable support.Server implementation: #624