Add server support for Connect HTTP GET requests #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's necessary to handle parsing and decoding URL query parameters ourselves due to the fact that JavaScript/the DOM lack the functionality needed to handle potentially binary data in URL-encoded form. In the future, we may be able to improve performance by determining if we need to do this using a regular expression.
timostamm
reviewed
May 9, 2023
Final consensus pending, but it can always be reverted later.
…hadwick/unary-get-support
reyawn
reviewed
May 10, 2023
…uild/connect-es into jchadwick/unary-get-server
…hadwick/unary-get-server
…hadwick/unary-get-server
timostamm
reviewed
May 12, 2023
| import { parseTimeout } from "./parse-timeout.js"; | ||
| import { paramMessage, paramBase64 } from "./query-params.js"; |
There was a problem hiding this comment.
Can you merge with import statement on line 73? The TypeScript language service can do that. Your IDE should have a command to organize imports.
There was a problem hiding this comment.
I ran organize imports. I didn't really realize it handled our import style correctly, because some other tsserver functions don't seem to handle it very well. Thanks for the tip.
Co-authored-by: Timo Stamm <ts@timostamm.de>
timostamm
approved these changes
May 12, 2023
|
Thanks for your help + additional tests! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for handling Connect HTTP GET requests in servers. We also expose
protocolNameandrequestMethodon handler context so that handlers can know how the RPC request was initiated.