Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak for 'error' on session during h2 requests #726

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

timostamm
Copy link
Member

Fixes #725 by removing the event listener completely. All session events are handled by the Http2SessionManager since #673, and I can't think of a reason we would need it here.

The reproduction for the leak from #725 (comment) passes now:

$ node -v
v18.17.0
$ node --trace-warnings repro-725.mjs
req 0
req 1
req 2
req 3
req 4
req 5
req 6
req 7
req 8
req 9
req 10
req 11

@timostamm timostamm merged commit 4d1580f into main Jul 21, 2023
2 checks passed
@timostamm timostamm deleted the tstamm/fix-session-error-event branch July 21, 2023 20:43
@timostamm timostamm mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event memory leak for 'error' on session during h2 requests
2 participants