Fix early event loop exit on nodejs when H2 sessions are in the verify state #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
LGTM.
Can you update the PR title description with more details? They are basically our changelog, and we should take the extra couple of minutes it takes to make it really easy to see what's changed from release notes, with a link to a PR providing details.
For example, this PR title:
Fix early event loop exit on Node.js when H2 sessions are in the
verifystate
... would be more likely to ring a bell for a user who saw an unexpected early exit in their client app.
| @@ -2,3 +2,4 @@ | |||
| /*.json | |||
| /dist/*/**/*.spec.js | |||
| /dist/*/**/*.spec.d.ts | |||
| /dist/*/testdata/ | |||
Comment on lines
+171
to
+172
| it("verify should keep the process alive", async function () { | ||
| const worker = new Worker( |
There was a problem hiding this comment.
Great idea to use a worker instead of a child process. I don't see an alternative to test the actual outcome, and I think it's worth it.
srikrsna-buf
changed the title
ping
srikrsna-buf
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix early event loop exit on nodejs when H2 sessions are in the verify state. We
unrefthe connections to avoid idle connections stopping the process from exiting. This results in a case where process exits when verification is required (last pinged time elapsed ping interval). We alwaysrefbefore a manualpingandunrefif it succeeds with empty streams.Used a worker to test the behavior. Not super happy about it but seemed better than a child process.
Fixes #860.