-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conformance test and update to protoc 25.0 #145
Conversation
|
||
// https://github.com/connectrpc/conformance/blob/main/cert/client.crt | ||
// cert issues: https://stackoverflow.com/questions/9210514/unable-to-find-valid-certification-path-to-requested-target-error-even-after-c | ||
private const val CLIENT_CERT = """-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to just read these in as resources instead of including them as string constants here. This will make it easier to update if we ever need to do so again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
@@ -72,7 +72,7 @@ class Conformance( | |||
private lateinit var testServiceConnectClient: TestServiceClient | |||
|
|||
companion object { | |||
private const val CONFORMANCE_VERSION = "0b07f579cb61ad89de24524d62f804a2b03b1acf" | |||
private const val CONFORMANCE_VERSION = "88f85130640b46c0837e0d58c0484d83a110f418" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New upstream version with updated certs (will expire in 10 years).
|
||
// https://github.com/connectrpc/conformance/blob/main/cert/client.crt | ||
// cert issues: https://stackoverflow.com/questions/9210514/unable-to-find-valid-certification-path-to-requested-target-error-even-after-c | ||
private const val CLIENT_CERT = """-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
No description provided.