Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with code generated from protoc-gen-connect-query #166

Closed
timostamm opened this issue Sep 13, 2023 · 0 comments · Fixed by #167
Closed

Compilation error with code generated from protoc-gen-connect-query #166

timostamm opened this issue Sep 13, 2023 · 0 comments · Fixed by #167
Assignees
Labels
Bug Something isn't working

Comments

@timostamm
Copy link
Member

With v0.4.3, protoc-gen-connect-query generates the following TypeScript (with the plugin option target=ts):

// ...
export const ElizaService = {
  typeName: "connectrpc.eliza.v1.ElizaService",
  methods: {
    // elided
  }
} as const;
// ...

With the plugin option target=js, the plugin also generates as const, which is a syntax error in JavaScript.

@timostamm timostamm added the Bug Something isn't working label Sep 13, 2023
@paul-sachs paul-sachs self-assigned this Sep 13, 2023
paul-sachs added a commit that referenced this issue Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants