Make option to omit trace events apply to streaming RPCs #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayjshah
approved these changes
Jul 7, 2023
akshayjshah
changed the title
renovate bot
referenced
this pull request
in open-feature/flagd
Jul 8, 2023
… to v0.4.0 (#739) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bufbuild/connect-opentelemetry-go](https://togithub.com/bufbuild/connect-opentelemetry-go) | require | minor | `v0.3.0` -> `v0.4.0` | --- ### Release Notes <details> <summary>bufbuild/connect-opentelemetry-go (github.com/bufbuild/connect-opentelemetry-go)</summary> ### [`v0.4.0`](https://togithub.com/bufbuild/connect-opentelemetry-go/releases/tag/v0.4.0) [Compare Source](https://togithub.com/bufbuild/connect-opentelemetry-go/compare/v0.3.0...v0.4.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Enhancements - Add option to omit trace events for unary RPCs by [@​jipperinbham](https://togithub.com/jipperinbham) in [https://github.com/bufbuild/connect-opentelemetry-go/pull/98](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/98) - Make option to omit trace events apply to streaming RPCs by [@​joshcarp](https://togithub.com/joshcarp) in [https://github.com/bufbuild/connect-opentelemetry-go/pull/123](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/123) ##### Bugfixes - Set status codes properly for HTTP 304s by [@​jhump](https://togithub.com/jhump) in [https://github.com/bufbuild/connect-opentelemetry-go/pull/120](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/120) - Set span status properly for HTTP 304s by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-opentelemetry-go/pull/121](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/121) - Update studio URL in README by [@​pkwarren](https://togithub.com/pkwarren) in [https://github.com/bufbuild/connect-opentelemetry-go/pull/124](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/124) ##### Other changes - Tighten internal linting for import aliases by [@​zchee](https://togithub.com/zchee) in [https://github.com/bufbuild/connect-opentelemetry-go/pull/116](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/116) #### New Contributors - [@​jhump](https://togithub.com/jhump) made their first contribution in [https://github.com/bufbuild/connect-opentelemetry-go/pull/120](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/120) - [@​jipperinbham](https://togithub.com/jipperinbham) made their first contribution in [https://github.com/bufbuild/connect-opentelemetry-go/pull/98](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/98) - [@​pkwarren](https://togithub.com/pkwarren) made their first contribution in [https://github.com/bufbuild/connect-opentelemetry-go/pull/124](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/124) - [@​zchee](https://togithub.com/zchee) made their first contribution in [https://github.com/bufbuild/connect-opentelemetry-go/pull/116](https://togithub.com/bufbuild/connect-opentelemetry-go/pull/116) **Full Changelog**: bufbuild/connect-opentelemetry-go@v0.3.0...v0.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNyIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
- Changes name of option from `OmitRPCEvents` to `OmitTraceEvents` to be more clear - Omits trace events for streaming too - Adds tests Closes: #92 --------- Co-authored-by: Akshay Shah <akshay@akshayshah.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OmitRPCEventstoOmitTraceEventsto be more clearCloses: Excessive span.AddEvent for request/response size #92