Fix building against recent (main branch) of PDAL. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasHeader was refactored in PDAL so that: scaleX(), scaleY(), scaleZ(), offsetX(), offsetY(), offsetZ() are now scale.x, scale.y, scale.z, offset.x, offset.y, offset.z as of PDAL/PDAL@dd00e3a7
rcoup
added a commit
to rcoup/entwine
that referenced
this pull request
Feb 11, 2022
LasHeader was refactored in PDAL/PDAL@dd00e3a7, (`main` post v2.3.0) so that: scaleX(), scaleY(), scaleZ(), offsetX(), offsetY(), offsetZ() are now scale.x, scale.y, scale.z, offset.x, offset.y, offset.z Add configure-time detection of the new API to cmake for both forward and backward compatibility. Based-on: connormanning#275
|
I added backwards compatibility for this change as #276 |
|
This has been fixed in PDAL with PDAL/PDAL#3682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LasHeader was refactored in PDAL so that:
scaleX(), scaleY(), scaleZ(), offsetX(), offsetY(), offsetZ()
are now
scale.x, scale.y, scale.z, offset.x, offset.y, offset.z
as of PDAL/PDAL@dd00e3a7