This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
removed unused code #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
reviewed
Oct 17, 2022
runtime/src/runtime/fvm.rs
Outdated
| @@ -12,7 +12,6 @@ use fvm_shared::crypto::signature::Signature; | |||
| use fvm_shared::econ::TokenAmount; | |||
| use fvm_shared::error::{ErrorNumber, ExitCode}; | |||
| use fvm_shared::piece::PieceInfo; | |||
| use fvm_shared::randomness::Randomness; | |||
| use fvm_shared::sector::{ | |||
There was a problem hiding this comment.
All the types that implement sector or storage-specific functions can also be removed.
adlrocha
reviewed
Oct 17, 2022
runtime/src/runtime/mod.rs
Outdated
| /// Runtime is the VM's internal runtime object. | ||
| /// this is everything that is accessible to actors, beyond parameters. | ||
| pub trait Runtime<BS: Blockstore>: Primitives + Verifier + RuntimePolicy { | ||
| pub trait Runtime<BS: Blockstore>: Primitives + Verifier { |
There was a problem hiding this comment.
Verifier can also be removed.
adlrocha
reviewed
Oct 17, 2022
runtime/src/test_utils.rs
Outdated
| @@ -21,7 +21,6 @@ use fvm_shared::crypto::signature::Signature; | |||
| use fvm_shared::econ::TokenAmount; | |||
| use fvm_shared::error::ExitCode; | |||
| use fvm_shared::piece::PieceInfo; | |||
| use fvm_shared::randomness::Randomness; | |||
| use fvm_shared::sector::{ | |||
There was a problem hiding this comment.
Same as above, these can probably be removed.
adlrocha
reviewed
Oct 17, 2022
runtime/src/test_utils.rs
Outdated
| entropy, | ||
| out, | ||
| }; | ||
| pub fn expect_get_randomness_from_beacon(&mut self) { |
There was a problem hiding this comment.
Why do we need to keep these? It is imposed by the trait definition? If this is the case, which one? I feel we can remove this from the runtime.
adlrocha
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
LGTM.
A few things before you merge:
- Consider adding also a brief description of what is included as part of the
fvm_utilsin the mainREADMEof the repo. - All storage-specific code (like
Verifierandsector-related features) can also be removed. - Consider removing functions like
expect_randomnessfrom the runtime trait definition if needed.
adlrocha
reviewed
Oct 17, 2022
adlrocha
reviewed
Oct 17, 2022
| This repo contains a series of crates that serve as utils for fvm develop and testing. | ||
| Here are some simple breakdowns: | ||
| - runtime: Contains the runtime wrapper for communicating with `fvm`. It provides some |
There was a problem hiding this comment.
TODO: Add an extended description of the runtime. Do you mind adding an issue to remind ourselves to do it in the future (I can probably take this one)
There was a problem hiding this comment.
Co-authored-by: adlrocha <adlrocha@tutamail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
randomness,runtime policy.tcidtoprimitivesand addedTAddresscratesrc/lib.rs.Tests