Require bool and int in PHPDoc to be consistent with PHP's scalar types #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasekPurchart
force-pushed
the
short-scalars
branch
from
3e8e0c2
to
23cc572
Compare
VasekPurchart
force-pushed
the
short-scalars
branch
from
23cc572
to
9d94b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Consistence standard was first assembled (around 2013) there was no inclination in PHP, which form (short/long) will be preferred and there were used differently in various places. So for consistence was the choice to go with the more verbose, as stated in the standard.
However with the introduction of scalar type hints in PHP 7, which support only short variants, it is clear which variant is preferred now and hopefully PHP will stick with it in other places.