Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Featured" section on Home Page if there are no cards #2890

Closed
devinbalkind opened this issue Sep 10, 2018 · 5 comments
Closed

Hide "Featured" section on Home Page if there are no cards #2890

devinbalkind opened this issue Sep 10, 2018 · 5 comments

Comments

@devinbalkind
Copy link

User Story

As an admin, I want the "Featured" section to disappear from the home page if there are no cards in it.

Why is this Needed?

If there are no cards then there is nothing to "feature" on the home page so the display of that section heading looks like an error.

Description

Type: Bug

Current Behavior

Currently if there are no cards on the homepage it still says "Featured"

image

Expected Behavior

Hide the entire section if there are no cards

image

Steps to reproduce

See home page.

Definition of Done

Section is hidden when there are no cards.

@devinbalkind devinbalkind changed the title Hide "Featured" section on Home Page if there are no Hide "Featured" section on Home Page if there are no cards Sep 10, 2018
@papayalabs
Copy link
Contributor

Working on this issue

@papayalabs
Copy link
Contributor

Hi @mlovic, could you approve this to work on it. Thanks!

@decabeza
Copy link
Collaborator

Hi @papayalabs, thanks for find this, and of course! you can work on it! 😌

Remember to hide the hole container:

<div class="small-12 column <%= 'large-8' if feed_processes_enabled? %>">
  <%= render "cards" %>
</div>

😉

@papayalabs
Copy link
Contributor

Hi @decabeza, excellent! Ok, thanks for the tip. :)

@javierm
Copy link
Member

javierm commented Dec 10, 2018

Closed via #2899. Thanks @papayalabs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants