-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Featured section on Home Page if there are no cards #2899
Hide Featured section on Home Page if there are no cards #2899
Conversation
Hi @papayalabs, could you include a before/after screenshot comparison for this PR? That'd be extremely helpful for CONSUL's changelog 😄 |
Hi @aitbw, of course! |
Hi @papayalabs! Could you please fix the indentation in your changes using two spaces. 🙏 Also would be marvelous include some specs to test if there are no cards, the "featured" title will not render. 😏 Thanks! |
Hi @decabeza! Sure, I will do it! |
<div class="small-12 column <%= 'large-8' if feed_processes_enabled? %>"> | ||
<%= render "cards" %> | ||
</div> | ||
<% if @cards.any? %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to remove the trailing whitespace on this line?
<div class="small-12 column <%= 'large-8' if feed_processes_enabled? %>"> | ||
<%= render "cards" %> | ||
</div> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to remove the trailing whitespace on this line?
@@ -143,4 +143,24 @@ def ie_alert_box_xpath | |||
"/html/body/div[@class='wrapper ']/comment()[contains(.,'ie-callout')]" | |||
end | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to remove the trailing whitespace on this line and a few more lines on this file?
@@ -143,4 +143,24 @@ def ie_alert_box_xpath | |||
"/html/body/div[@class='wrapper ']/comment()[contains(.,'ie-callout')]" | |||
end | |||
end | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't have consecutive blank lines AFAIK.
@papayalabs Thank you for this pull request! Everything looks great, particularly the fact we now have specs for this case 😄. I've only left a couple of comments about whitespace issues. |
References
Issue #2890
Objectives
Fix Issue #2890
Visual Changes
Before:
If there are no cards on the homepage it still says "Featured"
After:
If there are no cards on the homepage it does not says "Featured" anymore