Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep categories being shown when change proposal phase date on colaborative legislation processes #3558

Closed
decabeza opened this issue May 28, 2019 · 8 comments · Fixed by #3868

Comments

@decabeza
Copy link
Collaborator

decabeza commented May 28, 2019

Background

When a proposal phase of a collaborative legislation process is active, in the sidebar are shown the categories of the process.

When the admin change the date of the proposals phase the categories disappear from the sidebar.

What we need

Keep showing the categories in the sidebar although the proposal phase date is changed.

Screenshots

When the admin change the date of the proposals phase on /admin/legislation/processes/N/edit

Screenshot 2019-11-04 at 13 05 56

The categories disappear of /admin/legislation/processes/N/proposals this causes also are disappearing on the front view.

Screenshot 2019-11-03 at 19 00 36

Screenshot 2019-11-03 at 18 59 10

@andrewcameronsims
Copy link
Contributor

Hi, I'd like to take this issue if nobody is working on it?

@javierm
Copy link
Member

javierm commented Oct 20, 2019

@andrewcameronsims All yours! Thanks! 😄

@andrewcameronsims
Copy link
Contributor

andrewcameronsims commented Oct 27, 2019

Hello,

I've been attempting to recreate the issue described on my local machine and was hoping I could ask for some clarification. The background of this issue describes the application as failing to show the categories of the process after the proposals phase has passed (i.e., when the date-range of that phase no longer includes the current date). However, I am unable to replicate this situation; on my machine, these categories are shown in the sidebar even when the proposals phase has passed.

categories_active

I guess that I must be making some false assumption about this issue. Either, i) the sidebar which I am looking at here is not the same sidebar which is indicated in the background; or ii) the proposals phase is active even after the end date of that phase has passed. I was hoping that you could let me know what I am getting wrong here. This is my first attempt to contribute to a project of this kind so perhaps I am not seeing something that is obvious. Any clarification you could give would be very helpful.

Thanks so much :)

@javierm
Copy link
Member

javierm commented Oct 28, 2019

Hi @andrewcameronsims!

this issue describes the application as failing to show the categories of the process when the proposals phase is active

Just to clarify: is there a typo in this sentence? 🤔 The issue seems to state the categories are shown when the proposals phase ia active.

on my machine, these categories are shown in the sidebar even when the proposals phase has already passed

Maybe @decabeza can comment on this behavior 😉.

@andrewcameronsims
Copy link
Contributor

Yes, sorry, that is a typo! Edited.

@andrewcameronsims
Copy link
Contributor

@decabeza Gentle ping. :) Do you have any guidance on how to replicate the issue you have described above?

@decabeza decabeza changed the title Keep categories being shown for proposal phase of colaborative legislation processes when finished Keep categories being shown when change proposal phase date on colaborative legislation processes Nov 4, 2019
@decabeza
Copy link
Collaborator Author

decabeza commented Nov 4, 2019

Hi @andrewcameronsims,

Researching about this behaviour I found the real cause why the categories were disappearing. I updated the issue with more information. 😉

@andrewcameronsims
Copy link
Contributor

Fantastic, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants