Categories are still shown when properties of the legislation process are changed #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcameronsims
changed the title
javierm
reviewed
Nov 24, 2019
These changes fix a bug that causes categories of a legislation process to be wiped on update of the process. It also adds a regression test for this fix.
andrewcameronsims
force-pushed
the
legislation_categories_persist
branch
from
ba95373
to
5d3748d
Compare
javierm
approved these changes
Nov 25, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…ation_categories_persist Fix categories being removed when a legislation process is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #3558 : "Keep categories being shown when change proposal phase date on colaborative legislation processes"
Notes
In the issue, it is mentioned that date changes to the legislation process cause the categories of the process to be deleted. I discovered that this bug occurs when any change whatsoever is made to the process from the administrator view, not just date. That was because in the update action it calls set_tag_list even when there are no tags in the parameters, and this causes the tag list to be set to empty. The fix for this is to make the set_tag_list call to be conditional on the presence of tags in the parameters. I have also added to one of the existing specs to have confidence to know if this bug reoccurs. This spec fails now without my change, and passes with it. Hope it's ok!