i18n remove duplicate locale folders #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crowind in sending folders named `de-DE` eventhough the locale in those files is just `de` We did a previous PR[1] trying to make this consistent But Crowdin keeps sending[2] this inconsistent locale folder and locale codes. So removing the duplicate folders named `de`. The locale is still being properly displayed as we are using the code `de` as the locale in application.rb [1] #2963 [2] #3005
javierm
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
PR Crowdin bot: #3005
Objectives
Remove duplicate locale folders:
"de" https://crowdin.com/project/consul/de
"fa" https://crowdin.com/project/consul/fa
"pl" https://crowdin.com/project/consul/pl
"sq" https://crowdin.com/project/consul/sq
"sv" https://crowdin.com/project/consul/sv
Notes
Crowdin is sending folders named
de-DEeven though the locale in those files is justdeWe did a previous PR trying to make this consistent
But Crowdin keeps sending this inconsistent locale folder and locale codes.
So removing the duplicate folders named
deand just keeping the folderde-DEThe locales are still being properly displayed as we are using the simplified version of the locales in application.rb