Add Font Awesome icons #3606
Merged
Add Font Awesome icons #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
approved these changes
Jun 12, 2019
voodoorai2000
approved these changes
Jun 18, 2019
javierm
requested changes
Sep 10, 2019
Now can use all icons from https://fontawesome.com.
javierm
approved these changes
Oct 23, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Add Font Awesome icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Add Font Awesome icons using font-awesome-sass gem to replace the customised icons font.
Now you can use any icon from Free version of Font Awesome.
Visual Changes
First row shows "old" icons and second row the Font Awesome version.
Notes
You can still use existing icons with
<span class="icon-X"></span>markup but is highly recommended use the font-awesome-sass gem rails helper for example:<%= icon("far", "address-book", class: "my-class") %>