Limit Font Awesome imports to reduce CSS size #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
application_css
branch
2 times, most recently
from
2845033
to
b549eb4
Compare
javierm
force-pushed
the
reduce_font_awesome
branch
3 times, most recently
from
b8aa9db
to
a0f2577
Compare
javierm
force-pushed
the
reduce_font_awesome
branch
from
a0f2577
to
be3811a
Compare
javierm
force-pushed
the
reduce_font_awesome
branch
2 times, most recently
from
e4848e2
to
f9fde6b
Compare
We were using Font Awesome fonts and selectors to support the browsers
which don't support mask images (at the time of writing, about 5% of the
browsers). However, we were only importing the selectors in order to
extend them. This resulted in our compiled CSS including styles for
every Font Awesome icon (currenty, more than a thousand), even if we
only use a few of them.
So we're using Font Awesome variables instead of using the selectors it
provides. Since variables are only compiled in the CSS if they're
actually used, this reduces the size of our compiled CSS considerably.
In production environments, the size is reduced from 539KB to 475KB,
meaning we reduce its size in about 12%.
The downside here is we can't easily use Font Awesome variables in our
Sass mixins because we can't use interpolation in variable names (that
is, we can't use `$fa-var-#{icon}`). So we're using a map containing all
Font Awesome variables in order to access it in the mixin.
Note installations using `.fa-*` selectors will now have to add extra
`@import` clauses.
javierm
force-pushed
the
reduce_font_awesome
branch
from
f9fde6b
to
4d49ec8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We were using Font Awesome fonts and selectors to support the browsers which don't support mask images (as the time of writing, about 5% of the browsers). However, we were only importing the selectors in order to extend them. This resulted in our compiled CSS including styles for every Font Awesome icon (currenty, more than a thousand), even if we only use a few of them.
Objectives
Notes
With these changes, the size of the application.css file is reduced from 539KB to 475KB.
Release notes
.fa-icon_name) will now have to add extra@importclauses in thercustom.scssfile to import files likefont-awesome/icons. Another option for these installations would be to remove these classes/selectors and use ourhas-fa-iconmixin.