Remove unused rubocop rules #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_rubocop_rules
branch
from
937a6d3
to
ad2ac42
Compare
javierm
changed the base branch from
change_basic_rubocop_rules
to
add_spacing_rules
javierm
changed the base branch from
add_spacing_rules
to
change_basic_rubocop_rules
javierm
force-pushed
the
change_basic_rubocop_rules
branch
2 times, most recently
from
be81033
to
60949bb
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
ad2ac42
to
d45d90e
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
d45d90e
to
4e59890
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
60949bb
to
4a68574
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
4e59890
to
fe8a83f
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
4a68574
to
654b974
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
fe8a83f
to
70e3769
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
654b974
to
d519471
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
70e3769
to
f2e516c
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
d519471
to
b6fd326
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
f2e516c
to
148b2eb
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
b6fd326
to
b11c5aa
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
148b2eb
to
136e529
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
b11c5aa
to
f72301a
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
136e529
to
8bf72b3
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
f72301a
to
2406de8
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
8bf72b3
to
2e6d6eb
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
2406de8
to
39ba010
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
2e6d6eb
to
dcf5950
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
39ba010
to
476d7d2
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
dcf5950
to
0f4a402
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
476d7d2
to
8bb6fbf
Compare
javierm
force-pushed
the
remove_rubocop_rules
branch
from
0f4a402
to
6966063
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
2 times, most recently
from
c04ea2c
to
2243809
Compare
For performance purposes, we need to find bottlenecks in our application. Optimizing the performance of small methods doesn't make the application faster. I've kept a few cops because applying these ones IMHO make the code easier to read.
We don't have a gemspec file, so we don't need these ones.
This rule doesn't make sense with Rails 5 anymore, since breaking it will raise an error.
The code `where(id: ids)` is equivalent to `where(id: ids.uniq)`. Since Rails 5 uses `distinct` instead of `uniq` and in most cases where we use `uniq` with `pluck` we should simply remove the `uniq` call (as done in this commit), we're also removing the `Rails/UniqBeforePluck` rubocop rule.
We consider these rules either return false positives or we don't have a strong opinion about them.
We consider these rules either return false positives or we don't have a strong opinion about them.
Since we're using rubygems as the only source, this rule is not necessary.
Since we're ignoring this rule in many places, we're marking it in a different way so it's clear we're not as strict with this rule.
javierm
force-pushed
the
remove_rubocop_rules
branch
from
6966063
to
97ec877
Compare
javierm
added
Refactoring
Linters
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Remove unused rubocop rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
There are many rules in our
.rubocop.ymlfile which were defined years ago. Since then, we've added HoundCI to automatically warn us about coding style issues.We think many of them are either too strict or they report false positives, which might be confusing for contributors.
Objectives