Change basic rubocop rules #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 24, 2019
| @@ -56,7 +56,7 @@ def census_api_response | |||
| def fill_stats_fields | |||
| if in_census? | |||
| self.gender = census_api_response.gender | |||
| self.geozone_id = Geozone.select(:id).where(census_code: census_api_response.district_code).first.try(:id) | |||
| self.geozone_id = Geozone.select(:id).where(census_code: census_api_response.district_code).first&.id | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [111/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
| @@ -25,7 +25,7 @@ def show | |||
| .where.not(description: "").order(:given_order) | |||
|
|
|||
| @answers_by_question_id = {} | |||
| poll_answers = ::Poll::Answer.by_question(@poll.question_ids).by_author(current_user.try(:id)) | |||
| poll_answers = ::Poll::Answer.by_question(@poll.question_ids).by_author(current_user&.id) | |||
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - poll_answers. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
houndci-bot
reviewed
Jun 24, 2019
| @@ -18,7 +18,7 @@ | |||
| scenario "The username links to their public profile" do | |||
| click_link @user.name | |||
|
|
|||
| expect(current_path).to eq(user_path(@user)) | |||
| expect(page).to have_current_path(user_path(@user)) | |||
There was a problem hiding this comment.
RSpec/InstanceVariable: Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
javierm
force-pushed
the
change_basic_rubocop_rules
branch
2 times, most recently
from
be81033
to
60949bb
Compare
voodoorai2000
approved these changes
Jun 24, 2019
javierm
force-pushed
the
add_spacing_rules
branch
from
caa769b
to
92d44c4
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
2 times, most recently
from
4a68574
to
654b974
Compare
javierm
force-pushed
the
add_spacing_rules
branch
2 times, most recently
from
0a1e7ef
to
577d85d
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
2 times, most recently
from
d519471
to
b6fd326
Compare
javierm
force-pushed
the
add_spacing_rules
branch
from
577d85d
to
423646b
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
b6fd326
to
b11c5aa
Compare
javierm
force-pushed
the
add_spacing_rules
branch
from
423646b
to
c6faf08
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
b11c5aa
to
f72301a
Compare
javierm
force-pushed
the
add_spacing_rules
branch
from
c6faf08
to
008b9c7
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
f72301a
to
2406de8
Compare
javierm
force-pushed
the
add_spacing_rules
branch
from
008b9c7
to
b09d920
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
2406de8
to
39ba010
Compare
javierm
force-pushed
the
add_spacing_rules
branch
2 times, most recently
from
987099c
to
d0bd2b8
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
39ba010
to
476d7d2
Compare
javierm
force-pushed
the
add_spacing_rules
branch
from
d0bd2b8
to
f0bb01b
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
476d7d2
to
8bb6fbf
Compare
javierm
force-pushed
the
add_spacing_rules
branch
2 times, most recently
from
c13e709
to
f9ed186
Compare
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
8bb6fbf
to
c04ea2c
Compare
We use staging and preproduction environments, which are not valid by default. This rule is useful because misspelling the name of an environment might otherwise go unnoticed.
We're not using the InsecureProtocolSource rule because I don't feel it's necessary.
These are rules we were already applying. We've excluded the `factories` folder for some rules because there's a factory defining a `context` attribute, which rubocop thought was the `context` RSpec keyword.
javierm
force-pushed
the
change_basic_rubocop_rules
branch
from
c04ea2c
to
2243809
Compare
|
Travis failure is not related to this pull request. |
javierm
added
Refactoring
Linters
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…cop_rules Change basic rubocop rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives