Load custom locales after everything is loaded #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
custom_locales_check
branch
2 times, most recently
from
fccba59
to
c77d651
Compare
javierm
force-pushed
the
custom_locales_check
branch
from
c77d651
to
91856dc
Compare
The line:
```
config.i18n.load_path += Dir[Rails.root.join("config", "locales", "**", "*.{rb,yml}")]
```
Was adding every locale under the `config/locales` folder, including the
ones inside `config/locales/custom/`. The files were loaded in the same
order as listed using `ls -f`.
So if the custom locales were loaded before the folder
`config/locales/#{I18n.locale}`, the default locales would override the
custom ones, and we want the custom locales to override the default
ones so CONSUL is easier to customize.
javierm
force-pushed
the
custom_locales_check
branch
from
91856dc
to
0b1a490
Compare
|
Travis failure is not related to this pull request and will be fixed by #3661. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Load custom locales after everything is loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The line:
Was adding every locale under the
config/localesfolder, including the ones insideconfig/locales/custom/. The files were loaded in the same order as listed usingls -f.So if the custom locales were loaded before the folder
config/locales/#{I18n.locale}, the default locales would override the custom ones, and we want the custom locales to override the defaultones so CONSUL is easier to customize.
Objectives
Make sure custom locales are loaded after every other locale is loaded.