Fix table layout after selecting an investment #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2019
javierm
force-pushed
the
fix_investment_selection
branch
2 times, most recently
from
99c1d56
to
01703c7
Compare
javierm
force-pushed
the
fix_investment_selection
branch
from
01703c7
to
cbdd59c
Compare
javierm
force-pushed
the
fix_date_today
branch
from
b970c4c
to
71bad63
Compare
javierm
force-pushed
the
fix_investment_selection
branch
from
cbdd59c
to
ca2800f
Compare
javierm
changed the title
javierm
force-pushed
the
fix_investment_selection
branch
from
ca2800f
to
49e31ed
Compare
javierm
changed the title
javierm
changed the title
javierm
changed the title
javierm
force-pushed
the
fix_investment_selection
branch
from
49e31ed
to
a660904
Compare
javierm
changed the title
javierm
force-pushed
the
capybara_webmock
branch
4 times, most recently
from
a784261
to
8bb5462
Compare
javierm
force-pushed
the
fix_investment_selection
branch
from
49e31ed
to
2dda81d
Compare
javierm
force-pushed
the
fix_investment_selection
branch
from
2dda81d
to
dabd70e
Compare
javierm
changed the title
When we were inserting a row or replacing an existing one (just like we do when we click the link to select an investment), we were entering a row containing all columns, and all of them were displayed even if they had been excluded using the column selector. This caused the table to move in a strange way, which sometimes made the investment selection tests fail.
While the test should work without this assertion, the intention of the test is to check what happens if a user selects and investment and, once it's selected, clicks the "next" link.
javierm
force-pushed
the
fix_investment_selection
branch
from
dabd70e
to
cf5b538
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…lection Fix table layout after selecting an investment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix a bug which broke the table layout after selecting an investment, which added even the columns which were not supposed to be shown: