Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #3843

Merged
merged 5 commits into from
Nov 10, 2019
Merged

Remove unused code #3843

merged 5 commits into from
Nov 10, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Nov 9, 2019

References

Objectives

  • Remove code we no longer use

@javierm
Remove unused controller
e0cb204 
It was probably added by accident in commit 85c08da.
@javierm javierm self-assigned this Nov 9, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Nov 9, 2019
@javierm
Remove obsolete controller concern
23d132c 
It isn't used since commit 18f0697.
@javierm
Remove unused helper methods
3eda2de 
They aren't used since commits a658536, 3752f3a, 88a7a29, eef8ad1,
f67f058, 04910fe and 9181610. The method `image_bytes_to_megabytes`
was never used and is a duplicate of the method `bytes_to_megabytes`.
@javierm
Remove obsolete model
497b087 
It was replaced by Dashboard::AdministratorTask in commit e5f9cf6.
@javierm
Remove unused Voter methods
216d9e6 
AFAIK these methods were never used. In any case, the similar method
`set_demographic_info` was added in commit 6c34599.
@javierm javierm merged commit 83e97cb into master Nov 10, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Nov 10, 2019
@javierm javierm deleted the remove_unused_code branch November 10, 2019 00:04
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3843 from consul/remove_unused_code
3921143 
Remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javierm javierm

Labels
Maintenance
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and cleanup unused code report
1 participant
@javierm