Fixed issue when filling holes in grouped supports query

consuldemocracy · Sep 17, 2018 · a658536 · a658536
1 parent 42d4482
commit a658536
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/app/controllers/concerns/dashboard/group_supports.rb b/app/controllers/concerns/dashboard/group_supports.rb
@@ -29,15 +29,7 @@ def fill_holes(grouped_votes)
       (start_date(proposal.published_at.to_date)..end_date).each do |date|
         missing_key = grouping_key_for(date)
         next if grouped_votes.key? missing_key
-
-        previous_key = previous_key_for(date)
-        previous_value = if grouped_votes.key? previous_key
-                           grouped_votes[previous_key]
-                         else
-                           0
-                         end
-
-        grouped_votes[missing_key] = previous_value
+        grouped_votes[missing_key] = []
       end
 
       grouped_votes

diff --git a/app/controllers/dashboard/successful_supports_controller.rb b/app/controllers/dashboard/successful_supports_controller.rb
@@ -11,8 +11,8 @@ def index
 
   def accumulated_grouped_supports
     grouped_votes = grouped_supports(:voted_at)
-    accumulate_supports(grouped_votes)
     fill_holes(grouped_votes)
+    accumulate_supports(grouped_votes)
   end
 
   def supports

diff --git a/app/controllers/dashboard/supports_controller.rb b/app/controllers/dashboard/supports_controller.rb
@@ -11,8 +11,8 @@ def index
 
   def accumulated_supports
     grouped_votes = grouped_supports(:created_at)
-    accumulate_supports(grouped_votes)
     fill_holes(grouped_votes)
+    accumulate_supports(grouped_votes)
   end