Bump devise-security from 0.10.1 to 0.11.1 #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
devise_security
branch
from
6103b92
to
2d412f0
Compare
The original devise_security_extension gem has not been maintained for years. Its last release was version 0.10.0, and wasn't compatible with Rails 5, and so we were using its master branch. Since the gem was unmaintained, it was forked as devise-security and the aforementioned master branch was released as version 0.10.1. This version wasn't published in Rubygems, though, so we're now using the first version that was published in Rubygems and had a release announment [1]. Dependabot will probably open a pull request to upgrade to the latest version, but for now I'm trying to keep the devise-security gem as similar as the version we were using to make sure they're compatible, particularly considering we're monkey-patching some of the modules provided by this gem. [1] https://github.com/devise-security/devise-security/releases/tag/v0.11.1
javierm
force-pushed
the
devise_security
branch
from
2d412f0
to
dfb80b0
Compare
taitus
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
The original devise_security_extension gem has not been maintained for years. Its last release was version 0.10.0, and wasn't compatible with Rails 5, and so we were using its master branch.
Since the gem was unmaintained, it was forked as devise-security and the aforementioned master branch was released as version 0.10.1. This version wasn't published in Rubygems, though, and the first version that was published in Rubygems and had a release announment was version 0.11.1.
Objectives
Replace the unmaintaind Devise Security Extension gem with a maintained one.
Notes
Dependabot will probably open a pull request to upgrade to the latest version, but for now I'm trying to keep the devise-security gem as similar as the version we were using to make sure they're compatible, particularly considering we're monkey-patching some of the modules provided by this gem.