Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show money with hidden money #4900

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Do not show money with hidden money #4900

merged 1 commit into from
Feb 23, 2023

Conversation

decabeza
Copy link
Collaborator

@decabeza decabeza commented Aug 9, 2022

Objectives

During the balloting phase, the amounts of money appear in the progress bar and the list of investment projects even though the option "Hide money amount for this budget" was active for that budget.

@javierm javierm added this to Reviewing in Consul Democracy Aug 9, 2022
@taitus taitus self-assigned this Feb 20, 2023
@taitus taitus force-pushed the ballot_hidden_money branch 2 times, most recently from 115ffc6 to 4f98fb1 Compare February 20, 2023 13:22
Consul Democracy automation moved this from Reviewing to Testing Feb 20, 2023
@javierm javierm self-assigned this Feb 20, 2023
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taitus I've made some comments regarding the things you've changed. Let me know what you think!

spec/system/budgets/investments_spec.rb Outdated Show resolved Hide resolved
@javierm javierm moved this from Testing to Doing in Consul Democracy Feb 20, 2023
@taitus taitus requested a review from javierm February 20, 2023 17:39
@taitus taitus moved this from Doing to Reviewing in Consul Democracy Feb 20, 2023
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taitus I've left comments about a couple of typos in the tests titles. Everything else looks good to me 👍.

@javierm javierm moved this from Reviewing to Doing in Consul Democracy Feb 22, 2023
@taitus taitus moved this from Doing to Reviewing in Consul Democracy Feb 23, 2023
Consul Democracy automation moved this from Reviewing to Testing Feb 23, 2023
@taitus taitus merged commit 8f01a25 into master Feb 23, 2023
Consul Democracy automation moved this from Testing to Release 2.0.0 Feb 23, 2023
@taitus taitus deleted the ballot_hidden_money branch February 23, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants