Do not show money with hidden money

consuldemocracy · Feb 20, 2023 · 115ffc6 · 115ffc6
1 parent 4debff7
commit 115ffc6
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 11 deletions.
diff --git a/app/components/budgets/investments/ballot_component.html.erb b/app/components/budgets/investments/ballot_component.html.erb
@@ -4,9 +4,11 @@
       <span class="icon-check-circle"
             title="<%= t("budgets.investments.investment.already_added") %>">
       </span>
-      <p class="investment-project-amount">
-        <%= investment.formatted_price %>
-      </p>
+      <% if investment.should_show_price? %>
+        <p class="investment-project-amount">
+          <%= investment.formatted_price %>
+        </p>
+      <% end %>
       <% if investment.should_show_ballots? %>
         <%= button_to budget_ballot_line_path(id: investment.id,
                                               budget_id: investment.budget_id,
@@ -21,9 +23,11 @@
     </div>
   <% else %>
     <div class="add in-favor">
-      <p class="investment-project-amount">
-        <%= investment.formatted_price %>
-      </p>
+      <% if investment.should_show_price? %>
+        <p class="investment-project-amount">
+          <%= investment.formatted_price %>
+        </p>
+      <% end %>
       <% if investment.should_show_ballots? %>
         <%= button_to budget_ballot_lines_path(investment_id: investment.id,
                                                budget_id: investment.budget_id,

diff --git a/app/views/budgets/ballot/_progress_bar.html.erb b/app/views/budgets/ballot/_progress_bar.html.erb
@@ -10,5 +10,7 @@
 </div>
 
 <p id="amount_available" class="amount-available" style="width: <%= ballot.percentage_spent(heading) %>%">
-  <%= sanitize(ballot.amount_available_info(heading)) %>
+  <% if @budget.show_money? %>
+    <%= sanitize(ballot.amount_available_info(heading)) %>
+  <% end %>
 </p>
diff --git a/app/views/budgets/investments/_header.html.erb b/app/views/budgets/investments/_header.html.erb
@@ -51,10 +51,12 @@
             <h2 class="margin-top">
               <%= t("budgets.investments.index.by_heading", heading: @heading.name) %>
             </h2>
-            <h3>
-              <span class="tagline"><%= t("budgets.investments.header.price") %></span>
-              <%= @budget.formatted_heading_price(@heading) %>
-            </h3>
+            <% if @budget.show_money? %>
+              <h3>
+                <span class="tagline"><%= t("budgets.investments.header.price") %></span>
+                <%= @budget.formatted_heading_price(@heading) %>
+              </h3>
+            <% end %>
           <% end %>
         </div>
       </div>

diff --git a/spec/system/budgets/investments_spec.rb b/spec/system/budgets/investments_spec.rb
@@ -1498,6 +1498,42 @@ def investments_order
       end
     end
 
+    scenario "Do not show progress bar money or price with hidden money" do
+      budget_hide_money = create(:budget, :hide_money, phase: "balloting", voting_style: "approval")
+      group = create(:budget_group, budget: budget_hide_money)
+      heading = create(:budget_heading, name: "Heading without money", group: group)
+      user = create(:user, :level_two)
+      investment = create(:budget_investment, :feasible, :selected, budget: budget_hide_money,
+                                               heading: heading, price: 100)
+
+      visit budget_investments_path(budget_hide_money, heading: heading)
+
+      expect(page).not_to have_content budget.formatted_heading_price(heading).to_s
+      expect(page).not_to have_content "€"
+      expect(page).not_to have_css(".tagline")
+
+      within "#budget_investment_#{investment.id}" do
+        expect(page).not_to have_content "100"
+        expect(page).not_to have_content "€"
+      end
+
+      login_as(user)
+
+      visit budget_investments_path(budget_hide_money, heading: heading)
+
+      expect(page).to have_content "VOTES CAST: 0 / YOU CAN VOTE 1 PROJECT"
+      expect(page).not_to have_content "Available budget"
+
+      expect(page).to have_css("#progress_bar")
+      expect(page).to have_css("#amount_available")
+      expect(page).not_to have_css("#amount_spent")
+
+      within "#budget_investment_#{investment.id}" do
+        expect(page).not_to have_content "100"
+        expect(page).not_to have_content "€"
+      end
+    end
+
     scenario "Highlight voted heading" do
       budget.update!(phase: "balloting")
       user = create(:user, :level_two)