-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce number of requests in user tests
We were adding a `visit` in a `before` block but then we started some tests with another `visit`. We also destroyed records in the database in between, which increased the risk of database inconsistency since the process running the browser had already been started. Besides, some tests were wrong; they were visiting a page with the browser, then destroying records in the database, and then checking the page without reloading the browser. Since we aren't automatically refreshing the affected areas of the page, obviously the page content before and after destroying records is exactly the same, and the test was passing because it's testing content that isn't there in any situation.
- Loading branch information
Showing
1 changed file
with
36 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters