Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move shared component stylesheets to shared folder
We had an inconsistency where most stylesheets associated to a component would have the same relative path as their component, so if we had a component in `app/components/admin/whatever`, its associated stylesheet would be in `app/assets/stylesheets/admin/whatever`. There was one exception to this rule: stylesheets for components in `app/components/shared/` were placed in `app/assets/stylesheets/`. The reason was that we thought "well... if they're in the root folder, they're shared". However, this is confusing because in the root folder there are also stylesheets that aren't associated to a component. So we're creating the `app/assets/stylesheets/shared/` folder. This also means we don't have to manually add every stylesheet in this folder the the `application.scss` file. We aren't the same for JavaScript files because with JavaScript we still don't have a clear association between JavaScript files and components. Only a couple of them (`advanced_search.js` and `check_all_none.js`) would be good candidates, and the one for the advanced search form doesn't even use the `.advanced-search-form` selector that we use in the CSS file.
- Loading branch information
Showing
10 changed files
with
1 addition
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.