Deactivate ckeditor file uploads feature

This feature was not working so its better to disable it completely. By removing attachment_files endpoints related buttons and tabs from ckeditor UI are not shown to users anymore.
consuldemocracy · Apr 18, 2020 · 7466148 · 7466148
1 parent 526d161
commit 7466148
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/app/assets/javascripts/ckeditor/config.js b/app/assets/javascripts/ckeditor/config.js
@@ -8,13 +8,9 @@ CKEDITOR.editorConfig = function( config )
 
   config.forcePasteAsPlainText = true;
 
-  config.filebrowserBrowseUrl = "/ckeditor/attachment_files";
-  config.filebrowserFlashBrowseUrl = "/ckeditor/attachment_files";
-  config.filebrowserFlashUploadUrl = "/ckeditor/attachment_files";
   config.filebrowserImageBrowseLinkUrl = "/ckeditor/pictures";
   config.filebrowserImageBrowseUrl = "/ckeditor/pictures";
   config.filebrowserImageUploadUrl = "/ckeditor/pictures";
-  config.filebrowserUploadUrl = "/ckeditor/attachment_files";
   config.filebrowserUploadMethod = "form";
 
   config.allowedContent = true;

diff --git a/spec/features/ckeditor_spec.rb b/spec/features/ckeditor_spec.rb
@@ -30,4 +30,15 @@
 
     expect(page).to have_css "img[src$='clippy.jpg']"
   end
+
+  scenario "cannot upload attachments through link tab", :js do
+    login_as(create(:administrator).user)
+    visit new_admin_site_customization_page_path
+
+    find(".cke_button__link").click
+
+    expect(page).to have_css(".cke_dialog")
+    expect(page).not_to have_link "Upload"
+    expect(page).not_to have_link "Browse Server"
+  end
 end