Don't send newsletters to unconfirmed accounts (Merge #3781)

consuldemocracy · Oct 30, 2019 · 9fd79ce · 9fd79ce
1 parent bf7a8b4
commit 9fd79ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/user_segments.rb b/lib/user_segments.rb
@@ -10,7 +10,7 @@ class UserSegments
                 not_supported_on_current_budget].freeze
 
   def self.all_users
-    User.active
+    User.active.where.not(confirmed_at: nil)
   end
 
   def self.administrators

diff --git a/spec/models/newsletter_spec.rb b/spec/models/newsletter_spec.rb
@@ -50,6 +50,7 @@
   describe "#list_of_recipient_emails" do
     before do
       create(:user, newsletter: true, email: "newsletter_user@consul.dev")
+      create(:user, newsletter: true, email: "newsletter_unconfirmed_user@consul.dev", confirmed_at: nil)
       create(:user, newsletter: false, email: "no_news_user@consul.dev")
       create(:user, email: "erased_user@consul.dev").erase
       newsletter.update!(segment_recipient: "all_users")