Use Capybara to disable animations in tests

We were doing it manually, but Capybara offers an option which does the exact same thing. This way we also apply the NoJavascriptTagHelper ERB rule, which reported one error in the `disable_animations_in_tests` partial.
consuldemocracy · Feb 5, 2021 · b214205 · b214205
1 parent 1c2886d
commit b214205
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/.erb-lint.yml b/.erb-lint.yml
@@ -8,6 +8,8 @@ linters:
     enabled: true
   FinalNewline:
     enabled: true
+  NoJavascriptTagHelper:
+    enabled: true
   SelfClosingTag:
     enabled: false
   SpaceAroundErbTag:

diff --git a/app/views/layouts/_common_head.html.erb b/app/views/layouts/_common_head.html.erb
@@ -6,4 +6,3 @@
 <%= javascript_include_tag "application", "data-turbolinks-track" => "reload" %>
 <%= csrf_meta_tags %>
 <%= favicon_link_tag "favicon.ico" %>
-<%= render "layouts/disable_animations_in_tests" if Rails.env.test? %>
diff --git a/app/views/layouts/_disable_animations_in_tests.html.erb b/app/views/layouts/_disable_animations_in_tests.html.erb
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
@@ -47,5 +47,6 @@
 
 Capybara.exact = true
 Capybara.enable_aria_label = true
+Capybara.disable_animation = true
 
 OmniAuth.config.test_mode = true