Improved tests

consuldemocracy · Oct 3, 2018 · c03da34 · c03da34
1 parent bd0abf4
commit c03da34
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/spec/factories/legislations.rb b/spec/factories/legislations.rb
@@ -63,6 +63,18 @@
       result_publication_date { Date.current + 5.days }
     end
 
+    trait :in_proposals_phase do
+      proposals_phase_start_date { Date.current - 1.day }
+      proposals_phase_end_date { Date.current + 2.days }
+      proposals_phase_enabled true
+    end
+
+    trait :upcoming_proposals_phase do
+      proposals_phase_start_date { Date.current + 1.day }
+      proposals_phase_end_date { Date.current + 2.days }
+      proposals_phase_enabled true
+    end
+
     trait :published do
       published true
     end

diff --git a/spec/features/legislation/processes_spec.rb b/spec/features/legislation/processes_spec.rb
@@ -240,15 +240,15 @@
 
     context 'proposals phase' do
       scenario 'not open' do
-        process = create(:legislation_process, proposals_phase_start_date: Date.current + 1.day, proposals_phase_end_date: Date.current + 2.days)
+        process = create(:legislation_process, :upcoming_proposals_phase)
 
         visit legislation_process_proposals_path(process)
 
         expect(page).to have_content("This phase is not open yet")
       end
 
       scenario 'open' do
-        process = create(:legislation_process, proposals_phase_start_date: Date.current - 1.day, proposals_phase_end_date: Date.current + 2.days, proposals_phase_enabled: true)
+        process = create(:legislation_process, :in_proposals_phase)
 
         visit legislation_process_proposals_path(process)