Delete spending proposals

app/controllers/admin/api/stats_controller.rb

@@ -3,7 +3,6 @@ class Admin::Api::StatsController < Admin::Api::BaseController
   def show
     unless params[:event].present? ||
            params[:visits].present? ||
-           params[:spending_proposals].present? ||
            params[:budget_investments].present? ||
            params[:user_supported_budgets].present?
       return render json: {}, status: :bad_request
@@ -19,10 +18,6 @@ def show
       ds.add "Visits", Visit.group_by_day(:started_at).count
     end
 
-    if params[:spending_proposals].present?
-      ds.add "Spending proposals", SpendingProposal.group_by_day(:created_at).count
-    end
-
     if params[:budget_investments].present?
       ds.add "Budget Investments", Budget::Investment.group_by_day(:created_at).count
     end

app/controllers/admin/budget_investments_controller.rb

@@ -91,7 +91,7 @@ def load_budget
     end
 
     def load_investment
-      @investment = Budget::Investment.by_budget(@budget).find(params[:id])
+      @investment = @budget.investments.find(params[:id])
     end
 
     def load_admins

app/controllers/admin/stats_controller.rb

@@ -11,6 +11,7 @@ def show
     @debate_votes   = Vote.where(votable_type: "Debate").count
     @proposal_votes = Vote.where(votable_type: "Proposal").count
     @comment_votes  = Vote.where(votable_type: "Comment").count
+
     @votes = Vote.count
 
     @user_level_two   = User.active.level_two_verified.count
@@ -24,8 +25,6 @@ def show
                                                        .count(:voter_id)
 
     @user_ids_who_didnt_vote_proposals = @verified_users - @user_ids_who_voted_proposals
-
-    @spending_proposals = SpendingProposal.count
     budgets_ids = Budget.where.not(phase: "finished").pluck(:id)
     @budgets = budgets_ids.size
     @investments = Budget::Investment.where(budget_id: budgets_ids).count
@@ -52,7 +51,6 @@ def direct_messages
     @users_who_have_sent_message = DirectMessage.select(:sender_id).distinct.count
   end
 
-
   def budgets
     @budgets = Budget.all
   end

app/controllers/application_controller.rb

@@ -73,10 +73,6 @@ def set_proposal_votes(proposals)
       @proposal_votes = current_user ? current_user.proposal_votes(proposals) : {}
     end
 
-    def set_spending_proposal_votes(spending_proposals)
-      @spending_proposal_votes = current_user ? current_user.spending_proposal_votes(spending_proposals) : {}
-    end
-
     def set_comment_flags(comments)
       @comment_flags = current_user ? current_user.comment_flags(comments) : {}
     end

app/helpers/admin_helper.rb

@@ -33,10 +33,6 @@ def menu_budgets?
     controller_name.starts_with?("budget")
   end
 
-  def menu_budget?
-    ["spending_proposals"].include?(controller_name)
-  end
-
   def menu_polls?
     %w[polls active_polls recounts results questions answers].include?(controller_name) ||
     controller.class.parent == Admin::Poll::Questions::Answers

app/helpers/geozones_helper.rb

@@ -8,9 +8,4 @@ def geozone_select_options
     Geozone.all.order(name: :asc).collect { |g| [ g.name, g.id ] }
   end
 
-  def geozone_name_from_id(g_id)
-    @all_geozones ||= Geozone.all.collect{ |g| [ g.id, g.name ] }.to_h
-    @all_geozones[g_id] || t("geozones.none")
-  end
-
 end

app/helpers/settings_helper.rb

@@ -8,4 +8,4 @@ def setting
     @all_settings ||= Hash[ Setting.all.map{|s| [s.key, s.value.presence]} ]
   end
 
-end
+end

app/mailers/mailer.rb

@@ -37,16 +37,6 @@ def email_verification(user, recipient, token, document_type, document_number)
     end
   end
 
-  def unfeasible_spending_proposal(spending_proposal)
-    @spending_proposal = spending_proposal
-    @author = spending_proposal.author
-    @email_to = @author.email
-
-    with_user(@author) do
-      mail(to: @email_to, subject: t("mailers.unfeasible_spending_proposal.subject", code: @spending_proposal.code))
-    end
-  end
-
   def direct_message_for_receiver(direct_message)
     @direct_message = direct_message
     @receiver = @direct_message.receiver

app/models/abilities/common.rb

@@ -89,8 +89,6 @@ def initialize(user)
           proposal.published?
         end
         can :vote_featured, Proposal
-        can :vote, SpendingProposal
-        can :create, SpendingProposal
 
         can :vote, Legislation::Proposal
         can :vote_featured, Legislation::Proposal

app/models/abilities/everyone.rb

@@ -14,9 +14,8 @@ def initialize(user)
         poll.expired? && poll.stats_enabled?
       end
       can :read, Poll::Question
-      can [:read, :welcome], Budget
-      can :read, SpendingProposal
       can :read, User
+      can [:read, :welcome], Budget
       can [:read], Budget
       can [:read], Budget::Group
       can [:read, :print, :json_data], Budget::Investment

app/models/geozone.rb

@@ -3,7 +3,6 @@ class Geozone < ApplicationRecord
   include Graphqlable
 
   has_many :proposals
-  has_many :spending_proposals
   has_many :debates
   has_many :users
   validates :name, presence: true