Skip to content

Commit

Permalink
Bump factory_bot_rails from 4.8.2 to 6.2.0
Browse files Browse the repository at this point in the history
Note we're changing the parent strategy because its default value
changed in Factory Bot 5. We're keeping the old one so it's compatible
with our test suite.

We're also removing the rubocop rule for static attributes because in
factory bot 5 this syntax is invalid and will raise an error, so there's
no need for rubocop to remind us about it.

Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 4.8.2 to 6.2.0.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md)
- [Commits](thoughtbot/factory_bot_rails@v4.8.2...v6.2.0)

---
updated-dependencies:
- dependency-name: factory_bot_rails
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
  • Loading branch information
dependabot[bot] authored and javierm committed Aug 12, 2021
1 parent 0c02b78 commit ff20b8a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
3 changes: 0 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ Capybara/FeatureMethods:
Capybara/VisibilityMatcher:
Enabled: true

FactoryBot/AttributeDefinedStatically:
Enabled: true

FactoryBot/FactoryClassName:
Enabled: true

Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ group :development, :test do
gem "bullet", "~> 6.1.4"
gem "byebug", "~> 11.1.3"
gem "database_cleaner", "~> 2.0.1"
gem "factory_bot_rails", "~> 4.8.2"
gem "factory_bot_rails", "~> 6.2.0"
gem "faker", "~> 1.8.7"
gem "i18n-tasks", "~> 0.9.34"
gem "knapsack_pro", "~> 2.11.0"
Expand Down
12 changes: 6 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,11 @@ GEM
multi_json (>= 1.3)
rake
execjs (2.8.1)
factory_bot (4.8.2)
activesupport (>= 3.0.0)
factory_bot_rails (4.8.2)
factory_bot (~> 4.8.2)
railties (>= 3.0.0)
factory_bot (6.2.0)
activesupport (>= 5.0.0)
factory_bot_rails (6.2.0)
factory_bot (~> 6.2.0)
railties (>= 5.0.0)
faker (1.8.7)
i18n (>= 0.7)
faraday (1.7.0)
Expand Down Expand Up @@ -733,7 +733,7 @@ DEPENDENCIES
devise-security (~> 0.11.1)
email_spec (~> 2.2.0)
erb_lint (~> 0.0.37)
factory_bot_rails (~> 4.8.2)
factory_bot_rails (~> 6.2.0)
faker (~> 1.8.7)
font-awesome-sass (~> 5.15.1)
foundation-rails (~> 6.6.2.0)
Expand Down
2 changes: 2 additions & 0 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
end
end

FactoryBot.use_parent_strategy = false

Capybara.register_driver :headless_chrome do |app|
capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
"goog:chromeOptions" => {
Expand Down

0 comments on commit ff20b8a

Please sign in to comment.