Improve budget results #1738
Merged
Improve budget results #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * We should recalculate winners also when an incompatible investment is flagged as compatible again How: * Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible * Extending the Budget::Result model spec to cover that new scenario
Why: * As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners) How: * Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
Why: * A non-winner but compatible investment shouldn't be marked as incompatible How: * Show incompatilibility checkbox only if investment is winner or incompatible
voodoorai2000
approved these changes
Jul 10, 2017
|
BONUS: Included non-winner and incompatible investments hidden by default as requested at #1737 (comment) |
voodoorai2000
approved these changes
Jul 10, 2017
javierm
pushed a commit
to javierm/consul
that referenced
this pull request
Dec 7, 2018
…upstream_missing_spec [Upstream] Add missing feature spec: Proposal Notifications In-app notifications from the proposal's author group notifications for the same proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
How
.delayexplicitly, avoiding thehandle_asynchronouslythat modified all calls. efacd0dScreenshots
1.Highlight current heading && 3. Do not display incompatible investment's table if empty
4. Show incompatibility checkbox only if winner or incompatible (not for compatible non-winners)
Test
Extended coverage for all new scenarios. Better check each commit to see in detail
Deployment
As usual
Warnings
None