Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on budget results view & table #1748

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

bertocq
Copy link
Collaborator

@bertocq bertocq commented Jul 13, 2017

Where

What

Backport improvements done on Madrid's fork to the Budget Results page and investments table:

  • Using an instance variable instead of params to show what is the current heading
  • Order budget headings by id (asc)
  • Improve budget results title
  • Fallback to first budget's heading if none is passed by param on url

How

Manually merging relevant and compatible changes from that PR

Screenshots

screen shot 2017-07-13 at 12 09 23

Test

  • Checking the current heading link has the active css class, and its by default the first budget heading.

Deployment

  • As usual

Warnings

  • Still missing the Budget Stats part... will come back later for it

@bertocq bertocq force-pushed the chore/budget_results_madrid_improvements branch from 17e7cad to 705ef19 Compare July 17, 2017 18:34
@bertocq bertocq merged commit fca8d6b into master Jul 18, 2017
@bertocq bertocq deleted the chore/budget_results_madrid_improvements branch July 18, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants