Return datetime format for en locale #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @voodoorai2000 |
bertocq
approved these changes
Aug 10, 2017
There was a problem hiding this comment.
Sorry @artofhuman but Raimond is on holidays :) He won't be able to answer.
Yes that file it's lacking that string, and there are many other differences with the es version, problem might be that it's not being checked by the i18n tests. We've work to do to clean up all problems around localization files, still working with crowdin.com/project/consul to get it translated.
Nice catch! 👏 and thanks for your contribution :)
javierm
pushed a commit
to javierm/consul
that referenced
this pull request
Mar 6, 2019
…ve_crud_budgets [Improvement] CRUD budgets and content blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
This locale was deleted in this commit
0323f8e#diff-6cbca5f5322a2c7b3138cce1540517b6L25
For es locale, this key exists https://github.com/consul/consul/blob/master/config/locales/es/rails.yml#L199
What
Screenshots