Add base controller for Admin:Poll controller #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes consuldemocracy#1848 On branch aperez-fix-for-issue-1848 Changes to be committed: new file: app/controllers/admin/poll/base_controller.rb modified: app/controllers/admin/poll/booth_assignments_controller.rb modified: app/controllers/admin/poll/booths_controller.rb modified: app/controllers/admin/poll/officer_assignments_controller.rb modified: app/controllers/admin/poll/officers_controller.rb modified: app/controllers/admin/poll/polls_controller.rb modified: app/controllers/admin/poll/questions_controller.rb modified: app/controllers/admin/poll/recounts_controller.rb modified: app/controllers/admin/poll/results_controller.rb modified: app/controllers/admin/poll/shifts_controller.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
Fixes #1848
What
Solves #1848, which caused a RoutingError exception as well as a missing I18n key.
How
Created a
base_controller.rbfile underapp/admin/poll, with anamespacehelper method, similar to thebase_controller.rbfile underapp/admin/site_customization. Then, the parent classAdmin::BaseControllerwas replaced withAdmin::Poll::BaseControllerwhere necessary.Screenshots
Here's how the header looks when visiting
/admin/polls/.