Validate presence 'poll_id' attribute on Poll::Question model

[aitbw]

Where

Fixes #1831

What

Validates presence of poll_id attribute on Poll::Question model, which previously allowed a question to be created with no association to a poll

How

Added the necessary validation on the Poll::Question model

Screenshots

Here's how the form looks when a poll is not selected

Test

Added tests for both valid and invalid scenarios, also did a small refactor to improve DRYness for the related spec

[bertocq]

Nice spec cleanup!

[MariaCheca]

Looks good! 👍

[bertocq]

@aitbw only one problem with tests, I've run three times locally spec/features/admin/poll/polls_spec.rb and it always fails at:

  1) Admin polls Questions Poll show Add question to poll
     Failure/Error: question = create(:poll_question, poll: nil, title: 'Should we rebuild the city?')

     ActiveRecord::RecordInvalid:
       Validation failed: Poll can't be blank
     # ./spec/features/admin/poll/polls_spec.rb:186:in `block (4 levels) in <top (required)>'

Because of the poll: nil at https://github.com/wairbut-m2c/consul/blob/aperez-validate-poll-question-is-selected/spec/features/admin/poll/polls_spec.rb#L186

[aitbw]

I'll fix it right away. Should I fix the issue, rebase and update the PR or a new commit would be better, @bertocq?

[bertocq]

@aitbw I think in the same commit that you were expecting poll not to be nil that fix could be as well in context of the rest of the commit, right? "Same commit" I mean :)

[aitbw]

The failing spec is fixed, so you shouldn't have any problems with it, @bertocq :D

[voodoorai2000]

👍