Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Officer recounts, add Final&Totals votes #1919

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

bertocq
Copy link
Collaborator

@bertocq bertocq commented Sep 25, 2017

Where

Internal request

What

  • Remove Daily recount (by officer)
  • Add Final recount (by officer)
  • Add Total votes (automatic)

How

  • Picking changes from Madrid's fork

Screenshots

Before

screen shot 2017-09-25 at 18 44 43

After (with new cool Admin design by @decabeza )

screen shot 2017-09-25 at 18 53 39

Test

  • updated to cover new features

Deployment

  • As usual

Warnings

Don't worry about admin design .. its just that screenshot was taken on madrid's fork :) instead of on consul codebase (sorry for that, but we still don't have a nice dev_seeds for poll data on consul)

Copy link
Contributor

@MariaCheca MariaCheca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bertocq bertocq merged commit f2e44f0 into master Sep 26, 2017
@bertocq bertocq deleted the chore/remove_booth_assignment_officer_totals branch September 26, 2017 08:20
javierm pushed a commit to javierm/consul that referenced this pull request Mar 18, 2019
…_unanswerable

Display all polls for current booth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants