Admins can see the preview of the budgets' results before the balloti… #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng phase is finished. Cambios para hacer commit: modificado: app/models/abilities/administrator.rb modificado: app/views/budgets/show.html.erb modificado: spec/models/abilities/administrator_spec.rb modificado: spec/models/abilities/everyone_spec.rb
bertocq
approved these changes
Oct 2, 2017
This was referenced Oct 3, 2017
javierm
pushed a commit
to javierm/consul
that referenced
this pull request
Apr 1, 2019
…able_locales [Upstream] Add locales for Indonesian, Russian, Slovak and Somali
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Let the admins preview the results of the budget before the balloting phase finishes.
How
First, I added the permissions for the admins as seen in this commit. Second, I added the specs needed for user and admin, as seen here (user) and here (admin). Thrid, I made the button to see the results visible if the budget is in balloting phase and
current_userhas permissions to preview the results.Screenshots
There aren't big changes, but I'll add an image of the button shown in balloting phase.
Test
Tests were added for user and admin abilities related to the results page.
Deployment
Not apply.
Warnings
As it was specified in the issue, the results need to be calculated in admins budget section before they can be previewed.