Add Poll::Admin answer videos #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid an exception when seeding the database See PR consuldemocracy#1977
Changes required as per issues consuldemocracy#1855 and consuldemocracy#1951 Fixes PR consuldemocracy#1977, note n° 2
Poll::QuestionAnswer model was renamed to Poll::Question::Answer which made the previous I18n keys unavailable for the views See PR consuldemocracy#1977, commit 461410a
'poll_question_id' attribute was renamed to 'question_id' on PR consuldemocracy#1977, commit 4aaf681
|
👌 |
3 tasks
Closed
javierm
added a commit
to javierm/consul
that referenced
this pull request
May 29, 2019
…tor_stats_enabled Add options to show advanced stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
How
Screenshots
Test
Notes
The model created on this PR takes the custom validation for
video_urlimplemented in Allow only YouTube/Vimeo URLs on 'video_url' attribute #1854, which it's not DRY at all. @iagirre created a concern to solve Create a Video concern to abstractvideo_urlattributes #1865 and the PR is pending. As soon as that PR is done and merged, I'll handle the refactor to maximize DRYness.Some errors were made on Admin::Poll questions UI refactor #1977, but were fixed on this PR. See commits' description for further information.
Since Admin question answer documents #1988 is done and waiting for approval/merge, we should be careful when merging since both PRs handle the
routes.rbfile and English/Spanish locales, as well as the Questions 'show' view. This is important since we want to keep the markup clean and tidy