Remove valid answers usage #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of valid_answers, plus style fixes
bertocq
force-pushed
the
feature/2072#remove_question_valid_answers
branch
from
340b3c1
to
e9294f2
Compare
This was referenced Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
valid_answersattribute and fix its usage toPoll::Question::AnswerHow
Reviewing all usages, replacing most of them for
.question_answersand fixing the specs & factories & dev_seedsScreenshots
No need, underneath changes only.
Test
Fixed to use question_answers instead
Deployment
valid_answersto newPoll::Question::Answeror #2074 will destroy all values before they can be savedWarnings
None