Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll results #2082

Merged
merged 26 commits into from
Oct 23, 2017
Merged

Poll results #2082

merged 26 commits into from
Oct 23, 2017

Conversation

MariaCheca
Copy link
Contributor

@MariaCheca MariaCheca commented Oct 19, 2017

Where

⚠️ Do not merge until #2095 is merged ⚠️

What

How

  • Created #results method on Polls controller and new view to /polls/[:poll_id]/results.
  • Created #stats method on Polls controller and new view to /polls/[:poll_id]/stats.
  • Added new methods to Poll::Question and Poll::Question::Answer models to generate information needed for the Results and Stats content.
  • Added new subnavigation to switch betweeen Poll public view sections.
  • Added most_voted attribute to Poll::Question::Answers.

Screenshots

localhost-3000-polls-11-results
localhost-3000-polls-11-results 1
localhost-3000-polls-11

Test

As usual.

Deployment

As usual.

@decabeza decabeza changed the title [WIP] Poll results Poll results Oct 23, 2017
@voodoorai2000 voodoorai2000 merged commit 799b136 into master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants