Fix direct_messages_max_per_day set to nil
#2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set to nil, it should mean not zero, but "infinite".
|
I'm assuming the failure is unrelated, let me know if I'm wrong though. |
|
Thank you so much @deivid-rodriguez! |
|
No problem, thanks to you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set to nil, it should mean not zero, but "infinite".
Where
None.
What
The objective is that there's a way to have unlimited direct messages per day, and also that messages can be sent by default on a development setup, since it currently gives a "max messages per day reached" error that prevents every message from being sent.
How
I checked for the existance of the setting and skip validation in that case. This way we skip the automatic
nil.to_i(== 0) conversion leading to the current behavior.Screenshots
None.
Test
I added coverage.
Deployment
I don't think so.
Warnings
Nope. Well, maybe yes. If some installation is intentionally using this (buggy, in my opinion) behavior, they'll have to start being explicit about it and setSetting['direct_max_messages_per_day'] = 0.