Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable search by name/email on several Admin sections #2105

Merged
merged 5 commits into from
Oct 25, 2017

Conversation

aitbw
Copy link
Collaborator

@aitbw aitbw commented Oct 23, 2017

Where

What

  • Enable search by name or email on Administrators, Moderators, Valuators and Mangers on the Admin panel

How

  • Adapted related controllers to respond properly when a search is requested
  • Adapted related views to render the correct information
  • Added translations in English and Spanish
  • Removed deprecated views

Test

  • Increased coverage for the 4 modified sections

Notes

  • The Create Valuator spec is now marked as pending since the changes requested in Admin - Searches  #2092 affect the UI in such a way it's not clear how this feature is going to be implemented now. Please advice on this so I can update the PR accordingly. [FIXED, see commit cd8cf42]

@zamuro zamuro force-pushed the aperez-admin-search branch 2 times, most recently from 45043d1 to e55ccf5 Compare October 24, 2017 11:21
@decabeza
Copy link
Collaborator

Hi @aitbw, a little detail,

You need move the content of admin/valuators/_valuator.html.erb (L15-27) to admin/valuators/search.html.erb (now the option to adds valuator role after search has disappeared) and delete _valuator.html.erb partial if it's not necessary anymore.

🙏

@aitbw
Copy link
Collaborator Author

aitbw commented Oct 25, 2017

PR updated accordingly, @decabeza. :D

@decabeza decabeza merged commit ac957c5 into consuldemocracy:master Oct 25, 2017
@aitbw aitbw deleted the aperez-admin-search branch January 15, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants