Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean English/Spanish I18n keys #2109

Closed

Conversation

aitbw
Copy link
Collaborator

@aitbw aitbw commented Oct 26, 2017

Where

This PR closes #2093 once merged

What

  • Remove duplicated I18n keys

How

  • Removed duplicated keys
  • Fixed inconsistencies
  • Fixed typos / misspelled words
  • Fixed Spanish translations on English locales and viceversa
  • Adapted affected views to new I18n keys

Test

  • Fixed coverage for affected tests

Warnings

  • This a fairly "big" (as in there are several files modified) PR, so I would suggest merging this one before any other to keep merge conflicts as minimal as possible.

@zamuro zamuro force-pushed the aperez-clean-i18n-keys branch 4 times, most recently from 2a6ac1a to be62167 Compare October 27, 2017 15:44
* Removed duplicated keys
* Fixed inconsistencies
* Fixed typos / misspelled words
* Fixed Spanish translations on English locales and viceversa
* Adapted affected views to new I18n keys
@bertocq bertocq added this to the v0.12 milestone Nov 21, 2017
@bertocq bertocq removed this from the v0.13 milestone Jan 4, 2018
@aitbw aitbw mentioned this pull request Jan 16, 2018
@aitbw aitbw mentioned this pull request Feb 16, 2018
@aitbw
Copy link
Collaborator Author

aitbw commented Feb 16, 2018

Closed in favor of #2469 and upcoming smaller, easier to review PRs

@aitbw aitbw closed this Feb 16, 2018
@aitbw aitbw deleted the aperez-clean-i18n-keys branch March 28, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin - removes duplicated i18n
2 participants